UI stays no responsive when the amount entered with many decimals #456

Sharqiewicz · 2024-05-20T16:08:42Z

What:

When the amount for the bridge to Pendulum contains higher amount of decimals than 12, the UI remains no responsive. The inspect on the number gives an error attached in the screenshot below.

How:

Convert the input to proper extrinsic parameter type

Closes: #446

…row an error

netlify · 2024-05-20T16:08:58Z

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name	Link
🔨 Latest commit	`e22bc45`
🔍 Latest deploy log	https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66599780b28a4800089f78a6
😎 Deploy Preview	https://deploy-preview-456--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebma

Can confirm that it works as expected and fixes the bug.

src/hooks/spacewalk/useIssuePallet.tsx

…en-the-amount-entered-with-many-decimals

ebma

Very nice, thanks for refactoring 👍

prayagd

LGTM

…en-the-amount-entered-with-many-decimals

ebma · 2024-05-29T10:21:25Z

`yarn.lock` changes

Summary

Status	Count
	1
	119

Click to toggle table visibility

Name	Previous	Current
`@babel/code-frame`	7.24.2	7.24.6
`@babel/compat-data`	7.24.4	7.24.6
`@babel/core`	7.24.5	7.24.6
`@babel/generator`	7.24.5	7.24.6
`@babel/helper-annotate-as-pure`	7.22.5	7.24.6
`@babel/helper-builder-binary-assignment-operator-visitor`	7.22.15	7.24.6
`@babel/helper-compilation-targets`	7.23.6	7.24.6
`@babel/helper-create-class-features-plugin`	7.24.5	7.24.6
`@babel/helper-create-regexp-features-plugin`	7.22.15	7.24.6
`@babel/helper-environment-visitor`	7.22.20	7.24.6
`@babel/helper-function-name`	7.23.0	7.24.6
`@babel/helper-hoist-variables`	7.22.5	7.24.6
`@babel/helper-member-expression-to-functions`	7.24.5	7.24.6
`@babel/helper-module-imports`	7.24.3	7.24.6
`@babel/helper-module-transforms`	7.24.5	7.24.6
`@babel/helper-optimise-call-expression`	7.22.5	7.24.6
`@babel/helper-plugin-utils`	7.24.5	7.24.6
`@babel/helper-remap-async-to-generator`	7.22.20	7.24.6
`@babel/helper-replace-supers`	7.24.1	7.24.6
`@babel/helper-simple-access`	7.24.5	7.24.6
`@babel/helper-skip-transparent-expression-wrappers`	7.22.5	7.24.6
`@babel/helper-split-export-declaration`	7.24.5	7.24.6
`@babel/helper-string-parser`	7.24.1	7.24.6
`@babel/helper-validator-identifier`	7.24.5	7.24.6
`@babel/helper-validator-option`	7.23.5	7.24.6
`@babel/helper-wrap-function`	7.24.5	7.24.6
`@babel/helpers`	7.24.5	7.24.6
`@babel/highlight`	7.24.5	7.24.6
`@babel/parser`	7.24.5	7.24.6
`@babel/plugin-bugfix-firefox-class-in-computed-class-key`	7.24.5	7.24.6
`@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression`	7.24.1	7.24.6
`@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining`	7.24.1	7.24.6
`@babel/plugin-bugfix-v8-static-class-fields-redefine-readonly`	7.24.1	7.24.6
`@babel/plugin-syntax-flow`	7.24.1	7.24.6
`@babel/plugin-syntax-import-assertions`	7.24.1	7.24.6
`@babel/plugin-syntax-import-attributes`	7.24.1	7.24.6
`@babel/plugin-syntax-jsx`	7.24.1	7.24.6
`@babel/plugin-syntax-typescript`	7.24.1	7.24.6
`@babel/plugin-transform-arrow-functions`	7.24.1	7.24.6
`@babel/plugin-transform-async-generator-functions`	7.24.3	7.24.6
`@babel/plugin-transform-async-to-generator`	7.24.1	7.24.6
`@babel/plugin-transform-block-scoped-functions`	7.24.1	7.24.6
`@babel/plugin-transform-block-scoping`	7.24.5	7.24.6
`@babel/plugin-transform-class-properties`	7.24.1	7.24.6
`@babel/plugin-transform-class-static-block`	7.24.4	7.24.6
`@babel/plugin-transform-classes`	7.24.5	7.24.6
`@babel/plugin-transform-computed-properties`	7.24.1	7.24.6
`@babel/plugin-transform-destructuring`	7.24.5	7.24.6
`@babel/plugin-transform-dotall-regex`	7.24.1	7.24.6
`@babel/plugin-transform-duplicate-keys`	7.24.1	7.24.6
`@babel/plugin-transform-dynamic-import`	7.24.1	7.24.6
`@babel/plugin-transform-exponentiation-operator`	7.24.1	7.24.6
`@babel/plugin-transform-export-namespace-from`	7.24.1	7.24.6
`@babel/plugin-transform-flow-strip-types`	7.24.1	7.24.6
`@babel/plugin-transform-for-of`	7.24.1	7.24.6
`@babel/plugin-transform-function-name`	7.24.1	7.24.6
`@babel/plugin-transform-json-strings`	7.24.1	7.24.6
`@babel/plugin-transform-literals`	7.24.1	7.24.6
`@babel/plugin-transform-logical-assignment-operators`	7.24.1	7.24.6
`@babel/plugin-transform-member-expression-literals`	7.24.1	7.24.6
`@babel/plugin-transform-modules-amd`	7.24.1	7.24.6
`@babel/plugin-transform-modules-commonjs`	7.24.1	7.24.6
`@babel/plugin-transform-modules-systemjs`	7.24.1	7.24.6
`@babel/plugin-transform-modules-umd`	7.24.1	7.24.6
`@babel/plugin-transform-named-capturing-groups-regex`	7.22.5	7.24.6
`@babel/plugin-transform-new-target`	7.24.1	7.24.6
`@babel/plugin-transform-nullish-coalescing-operator`	7.24.1	7.24.6
`@babel/plugin-transform-numeric-separator`	7.24.1	7.24.6
`@babel/plugin-transform-object-rest-spread`	7.24.5	7.24.6
`@babel/plugin-transform-object-super`	7.24.1	7.24.6
`@babel/plugin-transform-optional-catch-binding`	7.24.1	7.24.6
`@babel/plugin-transform-optional-chaining`	7.24.5	7.24.6
`@babel/plugin-transform-parameters`	7.24.5	7.24.6
`@babel/plugin-transform-private-methods`	7.24.1	7.24.6
`@babel/plugin-transform-private-property-in-object`	7.24.5	7.24.6
`@babel/plugin-transform-property-literals`	7.24.1	7.24.6
`@babel/plugin-transform-react-display-name`	7.24.1	7.24.6
`@babel/plugin-transform-react-jsx`	7.23.4	7.24.6
`@babel/plugin-transform-react-jsx-development`	7.22.5	7.24.6
`@babel/plugin-transform-regenerator`	7.24.1	7.24.6
`@babel/plugin-transform-reserved-words`	7.24.1	7.24.6
`@babel/plugin-transform-shorthand-properties`	7.24.1	7.24.6
`@babel/plugin-transform-spread`	7.24.1	7.24.6
`@babel/plugin-transform-sticky-regex`	7.24.1	7.24.6
`@babel/plugin-transform-template-literals`	7.24.1	7.24.6
`@babel/plugin-transform-typeof-symbol`	7.24.5	7.24.6
`@babel/plugin-transform-typescript`	7.24.5	7.24.6
`@babel/plugin-transform-unicode-escapes`	7.24.1	7.24.6
`@babel/plugin-transform-unicode-property-regex`	7.24.1	7.24.6
`@babel/plugin-transform-unicode-regex`	7.24.1	7.24.6
`@babel/plugin-transform-unicode-sets-regex`	7.24.1	7.24.6
`@babel/preset-env`	7.24.5	7.24.6
`@babel/preset-typescript`	7.24.1	7.24.6
`@babel/runtime`	7.24.5	7.24.6
`@babel/template`	7.24.0	7.24.6
`@babel/traverse`	7.24.5	7.24.6
`@babel/types`	7.24.5	7.24.6
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@substrate/connect-known-chains`	1.1.4	1.1.5
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@types/react`	18.3.2	18.3.3
`caniuse-lite`	1.0.30001621	1.0.30001625
`cidr-regex`	4.0.5	4.1.1
`electron-to-chromium`	1.4.777	1.4.783
`eslint-plugin-react`	7.34.1	7.34.2
`glob`	10.3.16	10.4.1
`ini`	4.1.2	4.1.3
`is-cidr`	5.0.5	5.1.0
`memoizee`	0.4.15	0.4.17
`minipass`	7.1.1	7.1.2
`postcss-selector-parser`	6.0.16	6.1.0
`spdx-license-ids`	3.0.17	3.0.18
`type-fest`	4.18.2	4.18.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

Sharqiewicz · 2024-05-29T10:24:31Z

The InputField component has been renamed to NumericInput for better clarity. The NumericInput component now includes a maxDecimals property to specify the maximum number of decimal places allowed. By default, this is set to USER_INPUT_MAX_DECIMALS.PENDULUM.

We have defined an enum, USER_INPUT_MAX_DECIMALS, that includes all possible values for maxDecimals. Since we require a maximum of 7 decimal places for Stellar-related NumericInput components, we have also included USER_INPUT_MAX_DECIMALS.STELLAR.

ebma

Cool changes 👍 thanks for taking the time to also write tests.

I tested the input for the issuing/redeeming and they work great.

The staking view is broken for me on Pendulum (works on Foucoco). Console says 'too many re-renders'.

Also, let's use that input also in the input fields for staking. And eventually also for Nabla but I'm also fine if we only change that in the refactoring PR since nabla is currently using a different component.

src/components/Form/From/NumericInput/NumericInput.test.tsx

prayagd · 2024-05-30T05:44:47Z

@Sharqiewicz as soon i open the deploy preview this error is shown, even before interacting with the input field. Can we remove that error or is it intended?

Otherwise works are expected with 7 decimals

…en-the-amount-entered-with-many-decimals

ebma · 2024-05-30T12:55:19Z

`yarn.lock` changes

Summary

Status	Count
	1
	37

Click to toggle table visibility

Name	Previous	Current
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@npmcli/arborist`	7.5.2	7.5.3
`@npmcli/config`	8.3.2	8.3.3
`@npmcli/package-json`	5.1.0	5.1.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@typescript-eslint/eslint-plugin`	7.10.0	7.11.0
`@typescript-eslint/parser`	7.10.0	7.11.0
`@typescript-eslint/scope-manager`	7.10.0	7.11.0
`@typescript-eslint/type-utils`	7.10.0	7.11.0
`@typescript-eslint/types`	7.10.0	7.11.0
`@typescript-eslint/typescript-estree`	7.10.0	7.11.0
`@typescript-eslint/utils`	7.10.0	7.11.0
`@typescript-eslint/visitor-keys`	7.10.0	7.11.0
`@walletconnect/core`	2.13.0	2.13.1
`@walletconnect/sign-client`	2.13.0	2.13.1
`@walletconnect/types`	2.13.0	2.13.1
`@walletconnect/universal-provider`	2.13.0	2.13.1
`@walletconnect/utils`	2.13.0	2.13.1
`caniuse-lite`	1.0.30001623	1.0.30001625
`electron-to-chromium`	1.4.783	1.4.786
`eslint-plugin-react`	7.34.1	7.34.2
`libnpmdiff`	6.1.2	6.1.3
`libnpmexec`	8.1.1	8.1.2
`libnpmfund`	5.0.10	5.0.11
`libnpmpack`	7.0.2	7.0.3
`libnpmpublish`	9.0.8	9.0.9
`libnpmsearch`	7.0.5	7.0.6
`libnpmversion`	6.0.2	6.0.3
`loader-utils`	3.2.1	3.2.2
`npm`	10.8.0	10.8.1
`sass`	1.77.2	1.77.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

ebma · 2024-05-30T13:23:40Z

`yarn.lock` changes

Summary

Status	Count
	1
	37

Click to toggle table visibility

Name	Previous	Current
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@npmcli/arborist`	7.5.2	7.5.3
`@npmcli/config`	8.3.2	8.3.3
`@npmcli/package-json`	5.1.0	5.1.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@typescript-eslint/eslint-plugin`	7.10.0	7.11.0
`@typescript-eslint/parser`	7.10.0	7.11.0
`@typescript-eslint/scope-manager`	7.10.0	7.11.0
`@typescript-eslint/type-utils`	7.10.0	7.11.0
`@typescript-eslint/types`	7.10.0	7.11.0
`@typescript-eslint/typescript-estree`	7.10.0	7.11.0
`@typescript-eslint/utils`	7.10.0	7.11.0
`@typescript-eslint/visitor-keys`	7.10.0	7.11.0
`@walletconnect/core`	2.13.0	2.13.1
`@walletconnect/sign-client`	2.13.0	2.13.1
`@walletconnect/types`	2.13.0	2.13.1
`@walletconnect/universal-provider`	2.13.0	2.13.1
`@walletconnect/utils`	2.13.0	2.13.1
`caniuse-lite`	1.0.30001623	1.0.30001625
`electron-to-chromium`	1.4.783	1.4.786
`eslint-plugin-react`	7.34.1	7.34.2
`libnpmdiff`	6.1.2	6.1.3
`libnpmexec`	8.1.1	8.1.2
`libnpmfund`	5.0.10	5.0.11
`libnpmpack`	7.0.2	7.0.3
`libnpmpublish`	9.0.8	9.0.9
`libnpmsearch`	7.0.5	7.0.6
`libnpmversion`	6.0.2	6.0.3
`loader-utils`	3.2.1	3.2.2
`npm`	10.8.0	10.8.1
`sass`	1.77.2	1.77.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

ebma · 2024-05-30T15:29:53Z

`yarn.lock` changes

Summary

Status	Count
	1
	37

Click to toggle table visibility

Name	Previous	Current
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@npmcli/arborist`	7.5.2	7.5.3
`@npmcli/config`	8.3.2	8.3.3
`@npmcli/package-json`	5.1.0	5.1.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@typescript-eslint/eslint-plugin`	7.10.0	7.11.0
`@typescript-eslint/parser`	7.10.0	7.11.0
`@typescript-eslint/scope-manager`	7.10.0	7.11.0
`@typescript-eslint/type-utils`	7.10.0	7.11.0
`@typescript-eslint/types`	7.10.0	7.11.0
`@typescript-eslint/typescript-estree`	7.10.0	7.11.0
`@typescript-eslint/utils`	7.10.0	7.11.0
`@typescript-eslint/visitor-keys`	7.10.0	7.11.0
`@walletconnect/core`	2.13.0	2.13.1
`@walletconnect/sign-client`	2.13.0	2.13.1
`@walletconnect/types`	2.13.0	2.13.1
`@walletconnect/universal-provider`	2.13.0	2.13.1
`@walletconnect/utils`	2.13.0	2.13.1
`caniuse-lite`	1.0.30001623	1.0.30001625
`electron-to-chromium`	1.4.783	1.4.786
`eslint-plugin-react`	7.34.1	7.34.2
`libnpmdiff`	6.1.2	6.1.3
`libnpmexec`	8.1.1	8.1.2
`libnpmfund`	5.0.10	5.0.11
`libnpmpack`	7.0.2	7.0.3
`libnpmpublish`	9.0.8	9.0.9
`libnpmsearch`	7.0.5	7.0.6
`libnpmversion`	6.0.2	6.0.3
`loader-utils`	3.2.1	3.2.2
`npm`	10.8.0	10.8.1
`sass`	1.77.2	1.77.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

ebma

Also looks good to me 👍 can confirm that the staking page is not broken anymore.

Just one more thing, can we change the input field of the staking dialogs to use the new one you created and then limit the amounts to 12 decimals? I noticed that they still allow an unlimited number of decimals.

ebma · 2024-05-31T08:18:22Z

`yarn.lock` changes

Summary

Status	Count
	1
	37

Click to toggle table visibility

Name	Previous	Current
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@npmcli/arborist`	7.5.2	7.5.3
`@npmcli/config`	8.3.2	8.3.3
`@npmcli/package-json`	5.1.0	5.1.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@typescript-eslint/eslint-plugin`	7.10.0	7.11.0
`@typescript-eslint/parser`	7.10.0	7.11.0
`@typescript-eslint/scope-manager`	7.10.0	7.11.0
`@typescript-eslint/type-utils`	7.10.0	7.11.0
`@typescript-eslint/types`	7.10.0	7.11.0
`@typescript-eslint/typescript-estree`	7.10.0	7.11.0
`@typescript-eslint/utils`	7.10.0	7.11.0
`@typescript-eslint/visitor-keys`	7.10.0	7.11.0
`@walletconnect/core`	2.13.0	2.13.1
`@walletconnect/sign-client`	2.13.0	2.13.1
`@walletconnect/types`	2.13.0	2.13.1
`@walletconnect/universal-provider`	2.13.0	2.13.1
`@walletconnect/utils`	2.13.0	2.13.1
`caniuse-lite`	1.0.30001623	1.0.30001625
`electron-to-chromium`	1.4.783	1.4.786
`eslint-plugin-react`	7.34.1	7.34.2
`libnpmdiff`	6.1.2	6.1.3
`libnpmexec`	8.1.1	8.1.2
`libnpmfund`	5.0.10	5.0.11
`libnpmpack`	7.0.2	7.0.3
`libnpmpublish`	9.0.8	9.0.9
`libnpmsearch`	7.0.5	7.0.6
`libnpmversion`	6.0.2	6.0.3
`loader-utils`	3.2.1	3.2.2
`npm`	10.8.0	10.8.1
`sass`	1.77.2	1.77.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

Sharqiewicz · 2024-05-31T08:23:06Z

Also looks good to me 👍 can confirm that the staking page is not broken anymore.

Just one more thing, can we change the input field of the staking dialogs to use the new one you created and then limit the amounts to 12 decimals? I noticed that they still allow an unlimited number of decimals.

Very good catch @ebma ✅
I see that in Nabla we use a separate component called NumberInput, I think we should replace it with NumericInput to be consistent throughout the app, but I think we can separate this to another issue.

ebma

Tested and works like a charm, great job 🙏

src/components/Form/Amount/index.tsx

ebma · 2024-05-31T09:25:36Z

`yarn.lock` changes

Summary

Status	Count
	1
	37

Click to toggle table visibility

Name	Previous	Current
`@graphql-tools/delegate`	10.0.10	10.0.11
`@graphql-tools/documents`	1.0.0	1.0.1
`@graphql-tools/schema`	10.0.3	10.0.4
`@graphql-tools/utils`	10.2.0	10.2.1
`@npmcli/arborist`	7.5.2	7.5.3
`@npmcli/config`	8.3.2	8.3.3
`@npmcli/package-json`	5.1.0	5.1.1
`@peculiar/webcrypto`	1.4.6	1.5.0
`@testing-library/preact`	3.2.3	3.2.4
`@testing-library/user-event`	-	14.5.2
`@typescript-eslint/eslint-plugin`	7.10.0	7.11.0
`@typescript-eslint/parser`	7.10.0	7.11.0
`@typescript-eslint/scope-manager`	7.10.0	7.11.0
`@typescript-eslint/type-utils`	7.10.0	7.11.0
`@typescript-eslint/types`	7.10.0	7.11.0
`@typescript-eslint/typescript-estree`	7.10.0	7.11.0
`@typescript-eslint/utils`	7.10.0	7.11.0
`@typescript-eslint/visitor-keys`	7.10.0	7.11.0
`@walletconnect/core`	2.13.0	2.13.1
`@walletconnect/sign-client`	2.13.0	2.13.1
`@walletconnect/types`	2.13.0	2.13.1
`@walletconnect/universal-provider`	2.13.0	2.13.1
`@walletconnect/utils`	2.13.0	2.13.1
`caniuse-lite`	1.0.30001623	1.0.30001625
`electron-to-chromium`	1.4.783	1.4.786
`eslint-plugin-react`	7.34.1	7.34.2
`libnpmdiff`	6.1.2	6.1.3
`libnpmexec`	8.1.1	8.1.2
`libnpmfund`	5.0.10	5.0.11
`libnpmpack`	7.0.2	7.0.3
`libnpmpublish`	9.0.8	9.0.9
`libnpmsearch`	7.0.5	7.0.6
`libnpmversion`	6.0.2	6.0.3
`loader-utils`	3.2.1	3.2.2
`npm`	10.8.0	10.8.1
`sass`	1.77.2	1.77.3
`ua-parser-js`	1.0.37	1.0.38
`webcrypto-core`	1.7.9	1.8.0

ebma · 2024-05-31T09:26:06Z

Ready for merge.

convert the spacewalk bridge input to proper extrinsic type to not th…

4a29fce

…row an error

Sharqiewicz requested a review from ebma May 20, 2024 16:08

Sharqiewicz linked an issue May 20, 2024 that may be closed by this pull request

No bug and the UI stays no responsive when the amount entered with many decimals #446

Closed

2 tasks

Sharqiewicz requested a review from prayagd May 20, 2024 17:02

ebma approved these changes May 22, 2024

View reviewed changes

src/hooks/spacewalk/useIssuePallet.tsx Outdated Show resolved Hide resolved

Sharqiewicz added 3 commits May 23, 2024 19:30

Merge branch 'main' into 446-no-bug-and-the-ui-stays-no-responsive-wh…

54b9ef2

…en-the-amount-entered-with-many-decimals

fix requestIssue input type to be u128

31520d8

remove uneccessary comment

10dc0c7

ebma approved these changes May 24, 2024

View reviewed changes

prayagd approved these changes May 24, 2024

View reviewed changes

Sharqiewicz added 8 commits May 24, 2024 12:53

change function name from isU128 to isU128Compatible

211a4e3

refactor InputField to be NumericInput

0d7b004

add @testing-library/user-events for simulate user typing

d2070bc

refactor InputField to be NumericInput

7491055

Implement max decimals for NumericInput

324286f

update isU128Compatible

dff7190

implement max stellar decimal inputs for spacewalk bridge redeem

fedf258

Merge branch 'main' into 446-no-bug-and-the-ui-stays-no-responsive-wh…

df02757

…en-the-amount-entered-with-many-decimals

ebma reviewed May 29, 2024

View reviewed changes

src/components/Form/From/NumericInput/NumericInput.test.tsx Outdated Show resolved Hide resolved

src/components/Form/From/NumericInput/NumericInput.test.tsx Show resolved Hide resolved

Merge branch 'main' into 446-no-bug-and-the-ui-stays-no-responsive-wh…

2177426

…en-the-amount-entered-with-many-decimals

dont trigger error validation until form isDirty

3ed6087

fix lint error and NumericInput test

757d636

ebma reviewed May 30, 2024

View reviewed changes

use NumericInput for Amount component

82efa84

ebma approved these changes May 31, 2024

View reviewed changes

src/components/Form/Amount/index.tsx Outdated Show resolved Hide resolved

simplify code structure

e22bc45

Sharqiewicz merged commit 1a68016 into main May 31, 2024
5 checks passed

Sharqiewicz deleted the 446-no-bug-and-the-ui-stays-no-responsive-when-the-amount-entered-with-many-decimals branch May 31, 2024 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI stays no responsive when the amount entered with many decimals #456

UI stays no responsive when the amount entered with many decimals #456

Sharqiewicz commented May 20, 2024

netlify bot commented May 20, 2024 •

edited

Loading

ebma left a comment

ebma left a comment

prayagd left a comment

ebma commented May 29, 2024

Sharqiewicz commented May 29, 2024 •

edited

Loading

ebma left a comment

prayagd commented May 30, 2024 •

edited

Loading

ebma commented May 30, 2024

ebma commented May 30, 2024

ebma commented May 30, 2024

ebma left a comment

ebma commented May 31, 2024

Sharqiewicz commented May 31, 2024

ebma left a comment

ebma commented May 31, 2024

ebma commented May 31, 2024

UI stays no responsive when the amount entered with many decimals #456

UI stays no responsive when the amount entered with many decimals #456

Conversation

Sharqiewicz commented May 20, 2024

What:

How:

netlify bot commented May 20, 2024 • edited Loading

✅ Deploy Preview for rococo-souffle-a625f5 ready!

ebma left a comment

Choose a reason for hiding this comment

ebma left a comment

Choose a reason for hiding this comment

prayagd left a comment

Choose a reason for hiding this comment

ebma commented May 29, 2024

yarn.lock changes

Summary

Sharqiewicz commented May 29, 2024 • edited Loading

ebma left a comment

Choose a reason for hiding this comment

prayagd commented May 30, 2024 • edited Loading

ebma commented May 30, 2024

yarn.lock changes

Summary

ebma commented May 30, 2024

yarn.lock changes

Summary

ebma commented May 30, 2024

yarn.lock changes

Summary

ebma left a comment

Choose a reason for hiding this comment

ebma commented May 31, 2024

yarn.lock changes

Summary

Sharqiewicz commented May 31, 2024

ebma left a comment

Choose a reason for hiding this comment

ebma commented May 31, 2024

yarn.lock changes

Summary

ebma commented May 31, 2024

netlify bot commented May 20, 2024 •

edited

Loading

`yarn.lock` changes

Sharqiewicz commented May 29, 2024 •

edited

Loading

prayagd commented May 30, 2024 •

edited

Loading

`yarn.lock` changes

`yarn.lock` changes

`yarn.lock` changes

`yarn.lock` changes

`yarn.lock` changes